Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid text selection when shift pressed to select rows in obs summary table #4266

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Avoid text selection when shift pressed to select rows in obs summary table #4266

merged 1 commit into from
Oct 28, 2024

Conversation

rpiaggio
Copy link
Contributor

No description provided.

@mergify mergify bot added the explore label Oct 28, 2024
cquiroz
cquiroz approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cquiroz
cquiroz reviewed Oct 28, 2024
View reviewed changes
explore/src/main/scala/explore/observationtree/ObsSummaryTable.scala
@@ -431,7 +431,8 @@ object ObsSummaryTable:
innerContainerMod = ^.width := "100%",
containerRef = resizer.ref,
hoverableRows = rows.nonEmpty,
tableMod = ExploreStyles.ExploreTable |+| ExploreStyles.ObservationsSummaryTable,
tableMod =
ExploreStyles.ExploreTable |+| ExploreStyles.ObservationsSummaryTable |+| ExploreStyles.ExploreSelectableTable,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be rather ExploreUnselectableTable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I interpret it as "selectable rows".

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 28, 2024

BundleMon

Files updated (1)
Status Path Size Limits
✅ index-(hash).js
 1.74MB (+382B +0.02%) -
Unchanged files (7)
Status Path Size Limits
✅ exploreworkers-(hash).js
 606.06KB -
✅ index-(hash).css
 65.89KB -
✅ workbox-window.prod.es5-(hash).js
 2.07KB -
✅ plotworker-(hash).js
 88B -
✅ agsworker-(hash).js
 84B -
✅ itcworker-(hash).js
 77B -
✅ catalogworker-(hash).js
 76B -

Total files change +382B +0.02%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@rpiaggio rpiaggio merged commit 4d0b5f1 into master Oct 28, 2024
16 checks passed
@rpiaggio rpiaggio deleted the sc-3903-observation-summary-table-shift-click-selects branch October 28, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
explore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpiaggio @cquiroz