Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accessing menu when no program selected #4419

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

rpiaggio
Copy link
Contributor

This PR makes the program selection non modal when no program is defined.

This allows users to access the menu, and therefore change roles, logout, redeem invitations, etc. without the need to select a program. Consequently, the logout button is removed from the program selection popup.

The popup is still modal when accessed from "Manage programs" from inside a program. BTW, "Manage programs" is hidden when no program is defined.

@mergify mergify bot added the explore label Dec 22, 2024
Copy link

bundlemon bot commented Dec 22, 2024

BundleMon

Files updated (1)
Status Path Size Limits
index-(hash).js
1.71MB (-1.28KB -0.07%) -
Unchanged files (7)
Status Path Size Limits
exploreworkers-(hash).js
594.66KB -
index-(hash).css
66KB -
workbox-window.prod.es5-(hash).js
2.07KB -
catalogworker-(hash).js
90B -
agsworker-(hash).js
84B -
itcworker-(hash).js
83B -
plotworker-(hash).js
79B -

Total files change -1.28KB -0.05%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@cquiroz
Copy link
Contributor

cquiroz commented Dec 23, 2024

Great, I've been thinking about this for a whlie as there are scenarios where you don't want/need to select a program

Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpiaggio rpiaggio merged commit 04450c9 into master Dec 23, 2024
16 checks passed
@rpiaggio rpiaggio deleted the regular-program-select branch December 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants