Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented logs subscription in GraphQl. #448

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Implemented logs subscription in GraphQl. #448

merged 1 commit into from
Nov 7, 2023

Conversation

jluhrs
Copy link
Collaborator

@jluhrs jluhrs commented Nov 7, 2023

No description provided.

@mergify mergify bot added the server label Nov 7, 2023
cquiroz
cquiroz approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is this so clients can show whatever we are logging on the backend?
Maybe we need to copy it for observe

@jluhrs jluhrs merged commit 6b79489 into gemini-hlsw:main Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jluhrs @cquiroz