Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe guide #510

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Probe guide #510

merged 3 commits into from
Jan 30, 2024

Conversation

cquiroz
Copy link
Collaborator

@cquiroz cquiroz commented Jan 28, 2024

No description provided.

@cquiroz cquiroz requested a review from jluhrs January 28, 2024 23:11
@mergify mergify bot added the server label Jan 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (96620cf) 41.56% compared to head (e6d7577) 41.83%.

Files Patch % Lines
...a/navigate/server/tcs/TcsBaseControllerEpics.scala 58.33% 5 Missing ⚠️
...c/main/scala/navigate/server/tcs/TcsChannels.scala 0.00% 5 Missing ⚠️
.../navigate/web/server/http4s/NavigateMappings.scala 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   41.56%   41.83%   +0.27%     
==========================================
  Files          68       68              
  Lines        2300     2328      +28     
  Branches       11        6       -5     
==========================================
+ Hits          956      974      +18     
- Misses       1344     1354      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jluhrs jluhrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good, but I suggest to rename all the "guideMode" to "probeGuideMode". The former is too generic and may cause confusion.

@cquiroz cquiroz merged commit e7b42d1 into main Jan 30, 2024
4 checks passed
@cquiroz cquiroz deleted the probe-guide branch January 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants