Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use the gain reset channel name. #687

Conversation

jluhrs
Copy link
Collaborator

@jluhrs jluhrs commented Oct 7, 2024

I added a parameter to overwrite the default channel name in a previous PR, but forgot to actually use it when creating the channel.

@mergify mergify bot added the server label Oct 7, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.17%. Comparing base (9defe7a) to head (e447746).
Report is 86 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/scala/navigate/server/tcs/WfsChannels.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
- Coverage   52.58%   49.17%   -3.42%     
==========================================
  Files          55       69      +14     
  Lines        2628     3217     +589     
  Branches      230      304      +74     
==========================================
+ Hits         1382     1582     +200     
- Misses       1246     1635     +389     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jluhrs jluhrs merged commit d33c675 into gemini-hlsw:main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants