Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed OIWFS readout control. #693

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

jluhrs
Copy link
Collaborator

@jluhrs jluhrs commented Oct 10, 2024

Previous implementation set all OIWFS configuration through TCS, but it seems that some parts don't work. The solution was to copy the implementation from TCC, where those parts of the configuration are set directly on OIWFS.

@mergify mergify bot added the server label Oct 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.25000% with 35 lines in your changes missing coverage. Please review.

Project coverage is 49.26%. Comparing base (9defe7a) to head (7bf1855).
Report is 96 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/navigate/server/tcs/OiwfsEpicsSystem.scala 56.41% 17 Missing ⚠️
...main/scala/navigate/server/tcs/OiwfsChannels.scala 0.00% 8 Missing ⚠️
...rc/main/scala/navigate/server/NavigateEngine.scala 0.00% 6 Missing ⚠️
...erver/src/main/scala/navigate/server/Systems.scala 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
- Coverage   52.58%   49.26%   -3.33%     
==========================================
  Files          55       71      +16     
  Lines        2628     3264     +636     
  Branches      230      296      +66     
==========================================
+ Hits         1382     1608     +226     
- Misses       1246     1656     +410     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jluhrs jluhrs merged commit 9df5217 into gemini-hlsw:main Oct 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants