perf: provide diffBuffer in ImageDiffError #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
commented
Aug 7, 2023
| metaInfo = {}, | ||
| } = await Image.compare(refBuffer, currBuffer, imageCompareOpts); | ||
| Object.assign(refImg, metaInfo.refImg); | ||
|
|
||
| if (!equal) { | ||
| const diffBuffer = await diffImage.createBuffer("png"); |
There was a problem hiding this comment.
Тут передаю именно Buffer, потому что прототип потеряется, и методов save / createBuffer в html-reporter не будет
xrsd
approved these changes
Aug 21, 2023
KuznetsovRoman
force-pushed
the
HERMIONE-1088.hermione_diff_buffer
branch
from
698757d
to
e3f61ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что сделано
looks-samediffBuffer