Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix test id to be property and not a method in typings #785

Merged
merged 1 commit into from
Aug 22, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions typings/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@
}

export interface Suite extends Hermione.MochaSuite {
id(): string;
id: string;
browserId: string;
history: History;
}
Expand All @@ -257,7 +257,7 @@
*/
export interface History {
n: string;
a: any[];

Check warning on line 260 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (16.x)

Unexpected any. Specify a different type

Check warning on line 260 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (18.x)

Unexpected any. Specify a different type
ts: number;
te: number;
d: number;
Expand All @@ -274,7 +274,7 @@
}

export interface Test extends Hermione.MochaTest {
id(): string;
id: string;
browserId: string;
sessionId: string;
}
Expand Down Expand Up @@ -309,7 +309,7 @@
(expectation: string, callback?: TestDefinitionCallback): Test;
}

type TestDefinitionCallback = (this: TestDefinitionCallbackCtx, ctx: TestDefinitionCallbackCtx) => any;

Check warning on line 312 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (16.x)

Unexpected any. Specify a different type

Check warning on line 312 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (18.x)

Unexpected any. Specify a different type

export interface TestDefinitionCallbackCtx {
browser: WebdriverIO.Browser;
Expand Down Expand Up @@ -352,7 +352,7 @@
workerFilepath: string,
exportedMethods: ReadonlyArray<T>,
) => {
[K in (typeof exportedMethods)[number]]: (...args: Array<unknown>) => Promise<any> | any;

Check warning on line 355 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (16.x)

Unexpected any. Specify a different type

Check warning on line 355 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (16.x)

Unexpected any. Specify a different type

Check warning on line 355 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (18.x)

Unexpected any. Specify a different type

Check warning on line 355 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (18.x)

Unexpected any. Specify a different type
};

export interface Stats {
Expand All @@ -379,7 +379,7 @@
}

export interface GlobalHelper {
ctx: { [name: string]: any };

Check warning on line 382 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (16.x)

Unexpected any. Specify a different type

Check warning on line 382 in typings/index.d.ts

View workflow job for this annotation

GitHub Actions / build (18.x)

Unexpected any. Specify a different type
skip: SkipBuilder;
only: OnlyBuilder;
browser: (browserName: string) => BrowserConfigurator;
Expand Down
Loading