chore: remove modern-node-polyfills #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kabir-Ivan
force-pushed
the
remove-modern-node-polyfills
branch
from
0e34c36
to
a7c4834
Compare
shadowusr
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
If you tested it well and everything works on https://github.com/gemini-testing/testplane/tree/master/examples/component-testing, looks good to me (besides including the license)
src/runner/browser-env/vite/utils.ts
Outdated
| @@ -23,6 +26,33 @@ export const getNodeModulePath = async ({ | |||
| return resolve(moduleName, path.join(rootFileUrl, parent)); | |||
| }; | |||
|
|
|||
| // Just copy-pasted from modern-node-polyfills to avoid potential errors | |||
| export const polyfillPath = async (moduleName: string): Promise<string> => { | |||
There was a problem hiding this comment.
If this was taken from a MIT-licensed repo, you are required to include the corresponding license. For instance, you can create a separate file where in the beginning you copy-paste modern-node-polyfills' license to comment and then this code.
For our own ease of use, I'd also include a permalink to source file on github.
Kabir-Ivan
force-pushed
the
remove-modern-node-polyfills
branch
from
4f9d3c9
to
7425745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.