fix: fix typescript #995
Merged
fix: fix typescript #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kabir-Ivan
force-pushed
the
fix-typescript
branch
2 times, most recently
from
6157cd6
to
57d0b18
Compare
shadowusr
requested changes
Aug 15, 2024
| @@ -0,0 +1,3 @@ | |||
| declare module "clear-require" { | |||
There was a problem hiding this comment.
Is this used in order to avoid including @types/clear-require to production?
There was a problem hiding this comment.
No. There is no types package as I remember.
package.json
Outdated
| "@jspm/core": "2.0.1", | ||
| "@types/mocha": "10.0.1", | ||
| "@types/bluebird": "3.5.38", |
There was a problem hiding this comment.
It's not a mistake, is it, we really do need those in production deps?
There was a problem hiding this comment.
We do, but can be fixed by rewriting a few more files
shadowusr
force-pushed
the
fix-typescript
branch
from
41520fb
to
a874c27
Compare
shadowusr
approved these changes
Sep 2, 2024
KuznetsovRoman
approved these changes
Sep 2, 2024
|
Tested on a large project: https://nda.ya.ru/t/NGp9aTXW77yDqN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.