Update gpad-gpi-2-0.md #5347
Merged
Update gpad-gpi-2-0.md #5347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@balhoff , I *think* I made the changes in #4881 about slashes in local ID and the relation list. I'm not sure how to accomplish > allow other properties but require values of known properties to match grammar in table Can you approve this, if correct, and make the remaining change, or make all the remaining changes in a new PR?
|
@suzialeksander I think your changes look good! I talked to @pgaudet and we are going to check on the managers call whether we want to allow extra properties in the properties column. |
balhoff
approved these changes
Jul 22, 2024
|
To be discussed at this week's managers's call - @balhoff would like feedback as to whether we want to include this in the specs
This was to leave the option to have other, not yet defined properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@balhoff I think I made the changes in #4881 about slashes in local ID and the relation list.
I'm not sure how to accomplish
Can you approve this PR, if correct, and make the remaining change, or make all the remaining changes in a new PR?