Projection drive r

[dimalvovs]

@rpalaganas adding a pull request for (my) review here

[dimalvovs]

@rpalaganas thanks for a lot of comments, really helpful to understand what is happening. Also I think the variable names are well thought of, although some of them could have been shorter.

• Overall, I did not grasp the logical separation between functionality in plotting.R and projectionDriveRfun.R, especially in the light of projectionDriveRfun.R also doing plotting. Is all plotting in package being done through plotting? If yes, maybe projectionDriveRfun.R plotting should be moved there. If no, maybe plotting.R needs a name update.

projectionDriveRfun.R
The overall length of function code is quite large compared to arbitrary 50 line advisedlength, consider shortening. for example,

• there is no need to say warning(paste0('a', 'b')) as warning(a, b) works just in the same way.
• consider message instead of print, it works just in the same way as warning(), i.e. no need for paste()
• consider style: remove trailing spaces and some of line returns like lines 18-20, use <- instead of = etc,
• lines 107-124 can most probably written 2-3 lines e.g. using something likecbind and as.data.frame
• consider splitting CI and PV modes into separate funs
• stop does not require paste

plotting.R

• what are head rows up to line 11 meant for?
• same as previous function regards style, consider adding a linter, example
• same as above consider modularizing the and shrinking the lengthy functions, apart from more concise code maybe unweightedvolcano and weightedvolcano can become separate funs, or even there could be one parametrized fun for both?