Reorganize local storing of Tx #1569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plyhun
commented
Dec 29, 2023
core/src/main/java/com/gentics/mesh/core/endpoint/node/BinaryUploadHandlerImpl.java
Outdated
Show resolved
Hide resolved
plyhun
commented
Dec 29, 2023
| Tx.threadLocalGraph.set(tx); | ||
| Optional.ofNullable(Vertx.currentContext()) | ||
| .ifPresentOrElse( | ||
| ctx -> ctx.putLocal("tx", Optional.ofNullable(tx)), |
There was a problem hiding this comment.
The actual change. There are get() and getLocal() in the Vert.x Context, which seem to be functionally equal, but getLocal() has internal usages.
plyhun
commented
Dec 29, 2023
| return Tx.threadLocalGraph.get(); | ||
| Optional<Context> maybeVertxContext = Optional.ofNullable(Vertx.currentContext()); | ||
| if (maybeVertxContext.isPresent()) { | ||
| Context vertxContext = maybeVertxContext.get(); |
There was a problem hiding this comment.
Don't mix the cases where we have an empty Context, and where we have no Context at all.
plyhun
commented
Dec 29, 2023
...a/com/gentics/mesh/core/field/binary/AbstractBinaryFieldUploadEndpointParameterizedTest.java
Outdated
Show resolved
Hide resolved
plyhun
commented
Dec 29, 2023
tests/tests-core/src/main/java/com/gentics/mesh/core/graphql/GraphQLEndpointStressTest.java
Outdated
Show resolved
Hide resolved
|
Postponed by now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
One should never store a thing in ThreadLocal, since we operate async contexts, not threads.
Checklist
General
/CHANGELOG.adocOn API Changes