Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache import/export support #300

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

swrap
Copy link
Contributor

@swrap swrap commented Aug 21, 2020

Added in support to utilize moby/buildkit import-cache and export-cache fields. Updated the README to include all the information about the new fields. Thanks to @Chippiewill for all the help that he did through his #279 PR, really made this addition a lot easier. This is to support #263 and all to add the ability to utilize more caching by being able to export some cache! Also thanks to #287, helped me understand more by providing a better explanation for the README.

Let me know if anything needs changes! First time committing in this repo, so please be kind especially if I made any silly mistakes.

@swrap swrap marked this pull request as ready for review August 21, 2020 00:57
@AkihiroSuda
Copy link
Collaborator

AkihiroSuda commented Aug 31, 2020

Can we rather use cache-from and cache-to as in buildx?
https://github.com/docker/buildx#--cache-fromnametypetypekeyvalue

Also please squash commits

@swrap
Copy link
Contributor Author

swrap commented Aug 31, 2020

Can we rather use cache-from and cache-to as in buildx?
https://github.com/docker/buildx#--cache-fromnametypetypekeyvalue

Also please squash commits

Are those just a different naming convention for export-cache and import-cache or do they act differently?
Have not really used buildx, so I am not familiar with the similarities/differences.
I think they are, after looking through some src code, this is where the ops are changed over.

Yes I can squash.

@AkihiroSuda
Copy link
Collaborator

Just different convention

@swrap
Copy link
Contributor Author

swrap commented Aug 31, 2020

A little bit of a problem, #279 created cache-from to mimic the docker build cache-from and always run as inline. I think I will make changes to always consider inline unless otherwise specified. Your thoughts?

@AkihiroSuda
Copy link
Collaborator

Sgtm

build.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants