Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-344: update node and dependencies - #minor #226

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

benschs
Copy link
Contributor

@benschs benschs commented Apr 24, 2024

No description provided.

@benschs benschs requested a review from ltshb April 24, 2024 09:25
@github-actions github-actions bot changed the title PB-344: update node and dependencies PB-344: update node and dependencies - #minor Apr 24, 2024
@benschs benschs force-pushed the feat-PB-344-update-workflow branch from 3d1959b to 8797495 Compare April 24, 2024 09:27
Copy link
Contributor

@ltshb ltshb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me its look good but it cannot build somehow

@benschs benschs requested a review from ltshb April 24, 2024 11:14
@benschs
Copy link
Contributor Author

benschs commented Apr 24, 2024

@ltshb Workflows were missing the latest node version. Build passes now.

@benschs benschs merged commit 866b574 into master Apr 24, 2024
4 checks passed
@benschs benschs deleted the feat-PB-344-update-workflow branch April 24, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants