-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPBGDI_SB-3114: Added pipenv support - #minor #48
Conversation
ltflb-bgdi
commented
Mar 8, 2024
- Added pipenv support
- Fixed flask test query-string
274544b
to
2c0063d
Compare
Makefile
Outdated
PYTHON := $(PIPENV_RUN) python3 | ||
PYTHON := $(PIPENV_RUN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the line is too much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Done
Makefile
Outdated
rm -rf dist | ||
rm -rf build | ||
rm -rf *.egg-info | ||
rm -f .coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing those ? they are created when building a package if I remember well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Pipfile
Outdated
verify_ssl = true | ||
name = "pypi" | ||
|
||
[packages] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be all be put in dev-packages
this library has no direct dependencies.
I would only keep the main depencencies and let pip handle the dependencies of dependencise, so you should only have the followings:
- pylint
- isort
- yapft
- coverage
- django
- flask
- nose2
- packaging
- requests
- twine
I might have forgotten some, needs to be tested. I would also only fix the minor version so using ~=
instead of ==
as best practice.
c113944
to
92c30a3
Compare
Makefile
Outdated
# .PHONY: ci | ||
# ci: $(REQUIREMENTS) | ||
# # Create virtual env with all packages for development using the Pipfile.lock | ||
# pipenv sync --dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up
Added pipenv support
92c30a3
to
a5722db
Compare