Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1115: Validate all models on save #45

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

msom
Copy link
Contributor

@msom msom commented Nov 27, 2024

Currently, only the user model undergoes validation upon saving. This could result in scenarios where providers, attributions, and datasets are imported from the BOD but cannot be edited through the admin UI. Additionally, the slug field used in datasets is incompatible with existing datasets, as it does not support periods.

This PR introduces model validation across all models to ensure consistency and implements a custom slug field that supports periods.

@msom msom requested a review from benschs November 27, 2024 06:59
@github-actions github-actions bot added the bug label Nov 27, 2024
Copy link
Contributor

@benschs benschs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. 🐛 (slug)

@msom msom merged commit 75b70c0 into develop Nov 27, 2024
3 checks passed
@msom msom deleted the fix-PB-1115-validate-models branch November 27, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants