PB-569 Update documentation to use docker compose plugin #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansmannj
reviewed
Aug 13, 2024
README.md
Outdated
| @@ -44,7 +44,7 @@ See also [Git Flow - Versioning](https://github.com/geoadmin/doc-guidelines/blob | |||
|
|
|||
| ### Make Dependencies | |||
|
|
|||
| The **Make** targets assume you have **python3.11**, **pipenv**, **bash**, **curl**, **tar**, **docker** and **docker-compose** installed. | |||
| The **Make** targets assume you have **python3.11**, **pipenv**, **bash**, **curl**, **tar**, **docker** and **docker compose** installed. | |||
There was a problem hiding this comment.
As in geoadmin/service-shortlink#67 but probably I misunderstood something, sorry.
But wouldn't it be docker-compose-plugin here, instead of `docker and docker compose"?
There was a problem hiding this comment.
You're right, that's the proper naming for it, thank you!! 🧠
Instead of the legacy docker-compose
schtibe
force-pushed
the
feat-pb-569-switch-to-docker-compose-plugin
branch
from
d5be4c8 to
b320c51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the legacy docker-compose