PB-118: Take into account the GET key limit as well on bbox searches #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltclm
reviewed
Mar 13, 2024
ltclm
approved these changes
Mar 13, 2024
| @@ -197,7 +197,8 @@ def _swiss_search(self): # pylint: disable=too-many-branches, too-many-statemen | |||
| coords = self._get_geoanchor_from_bbox() | |||
| self.sphinx.SetGeoAnchor('lat', 'lon', coords[1], coords[0]) # pylint: disable=unsubscriptable-object | |||
| self.sphinx.SetSortMode(sphinxapi.SPH_SORT_EXTENDED, '@geodist ASC') | |||
| limit = self.BBOX_SEARCH_LIMIT | |||
| limit = self.limit if self.limit and \ | |||
There was a problem hiding this comment.
could be simplified by limit = min(self.limit, self.BBOX_SEARCH_LIMT) Of course for this to work both parameter needs to be numbers
rebert
force-pushed
the
fix-PB-118-limit-on-bbox-extends-searches
branch
2 times, most recently
from
078b0fc to
004ed1b
Compare
rebert
changed the title
rebert
force-pushed
the
fix-PB-118-limit-on-bbox-extends-searches
branch
from
004ed1b to
650b009
Compare
rebert
force-pushed
the
fix-PB-118-limit-on-bbox-extends-searches
branch
from
650b009 to
da96e38
Compare
|
e2e-tests passed successfully on this pr |
ltshb
approved these changes
Mar 18, 2024
| @@ -197,7 +197,8 @@ def _swiss_search(self): # pylint: disable=too-many-branches, too-many-statemen | |||
| coords = self._get_geoanchor_from_bbox() | |||
| self.sphinx.SetGeoAnchor('lat', 'lon', coords[1], coords[0]) # pylint: disable=unsubscriptable-object | |||
| self.sphinx.SetSortMode(sphinxapi.SPH_SORT_EXTENDED, '@geodist ASC') | |||
| limit = self.BBOX_SEARCH_LIMIT | |||
| limit = self.limit if self.limit and \ | |||
There was a problem hiding this comment.
could be simplified by limit = min(self.limit, self.BBOX_SEARCH_LIMT) Of course for this to work both parameter needs to be numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.