Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1128: fix permalink custom attributes #1137

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

sommerfe
Copy link
Contributor

@sommerfe sommerfe commented Nov 26, 2024

@sommerfe sommerfe self-assigned this Nov 26, 2024
@github-actions github-actions bot added the bug label Nov 26, 2024
@sommerfe sommerfe force-pushed the fix-pb-1128-permalink-problem branch from cb1aef6 to 2362d2f Compare November 26, 2024 10:20
Copy link

cypress bot commented Nov 26, 2024

web-mapviewer    Run #3914

Run Properties:  status check passed Passed #3914  •  git commit 64cf53f836: PB-1128: add test
Project web-mapviewer
Branch Review fix-pb-1128-permalink-problem
Run status status check passed Passed #3914
Run duration 05m 19s
Commit git commit 64cf53f836: PB-1128: add test
Committer Felix Sommer
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 213
View all changes introduced in this branch ↗︎

@sommerfe sommerfe force-pushed the fix-pb-1128-permalink-problem branch from aecaa21 to aaf2ada Compare November 26, 2024 12:55
@sommerfe sommerfe requested review from pakb and ltshb November 26, 2024 12:56
@sommerfe sommerfe marked this pull request as ready for review November 26, 2024 12:56
@pakb pakb force-pushed the fix-pb-1128-permalink-problem branch from aaf2ada to 64cf53f Compare November 26, 2024 13:54
@pakb pakb merged commit 0e9fc33 into develop Nov 26, 2024
6 checks passed
@pakb pakb deleted the fix-pb-1128-permalink-problem branch November 26, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants