Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix deprecation from PHPUnit #1217

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Chris53897
Copy link
Contributor

There was 1 warning:

1) Geocoder\Provider\GeoIP2\Tests\GeoIP2AdapterTest::testReaderResponseIsJsonEncoded
assertObjectHasAttribute() is deprecated and will be removed in PHPUnit 10. Refactor your test to use assertObjectHasProperty() instead.

@jbelien jbelien added the on hold label Mar 2, 2024
@jbelien jbelien marked this pull request as draft March 2, 2024 11:09
@jbelien
Copy link
Member

jbelien commented Mar 2, 2024

That breaks all "(low)" checks. I would wait until we upgrade to PHPUnit 10 before making that change.

@Chris53897
Copy link
Contributor Author

This is maybe solved by #1218 with Raising minimum PHPUnit version to 9.6 (or 9.6.x)

@Chris53897
Copy link
Contributor Author

Bumping the minium PHPUnit version, solved this problem.
But of course this is up to you, to wait until PHPUnit 10+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants