Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Here Geocode and Reverse Geocode Provider to GS7 (v7) #1229

Closed
wants to merge 13 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Common/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

## 4.7.0

### Added

- Add support for providers that use alternative queries to string search

## 4.6.0

### Removed
Expand Down
8 changes: 4 additions & 4 deletions src/Common/Query/GeocodeQuery.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ final class GeocodeQuery implements Query
/**
* The address or text that should be geocoded.
*
* @var string
* @var string|null
*/
private $text;

Expand All @@ -48,7 +48,7 @@ final class GeocodeQuery implements Query
*/
private $data = [];

private function __construct(string $text)
private function __construct(?string $text)
{
if ('' === $text) {
throw new InvalidArgument('Geocode query cannot be empty');
Expand All @@ -57,7 +57,7 @@ private function __construct(string $text)
$this->text = $text;
}

public static function create(string $text): self
public static function create(?string $text): self
{
return new self($text);
}
Expand Down Expand Up @@ -102,7 +102,7 @@ public function withData(string $name, mixed $value): self
return $new;
}

public function getText(): string
public function getText(): ?string
{
return $this->text;
}
Expand Down
10 changes: 10 additions & 0 deletions src/Provider/Here/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@

The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

## 0.8.0

### Added

- Add support for GS7 API as per https://www.here.com/docs/bundle/geocoding-and-search-api-v7-api-reference/page/index.html

### Removed

- Drop support for Geocode version 6

## 0.7.1

### Fixed
Expand Down
Loading