-
-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert ml stuff #1124
Merged
Merged
Revert ml stuff #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the latest mlr3 version is a breaking change (https://github.com/mlr-org/mlr3/releases/tag/v0.21.0) how fallback learners are defined (see also #1111). I have addressed this, let's what comes next -:) |
Robinlovelace
approved these changes
Sep 25, 2024
Robinlovelace
requested changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge after actions passing.
Great job, thanks Jannes, will merge! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Revert "eval=FALSE in c15" This reverts commit 80872c3. * Revert "store_backends" This reverts commit e6f74bd. * Revert "Remove cache from chunk 15-eco-26" This reverts commit 7217843. * Revert "Try evaluating train function" This reverts commit 6302bc7. * Revert "Update 15-tune.rds, fix actions (hopefully)" This reverts commit 737cbfc. * Revert "Do not evaluate failing mlr3::lrn chunk (#1111 hotfix)" This reverts commit b402780. * set eval=TRUE and save 15-tune.rds anew * use new method of specifying a fallback learner (breaking change, see https://github.com/mlr-org/mlr3/releases/tag/v0.21.0) * rebuild the autotuner bfb40b7
This was referenced Sep 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.