Builder #70
Open
Builder #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included Builder pattern for Genome class. This pattern simplifies the creation of the object and makes it
less error prone. Objects created with Builder pattern are non modifiable and are threadsafe.
Earlier the python code was using genome as a string. This could be error prone as any wrongly written code could
make changes to the genome causing errors. The entites could be in inconsistent state.
Builder pattern takes care of all these problems.
Apart from the genomeBuilder I have also provided a generic genome builder. Which expresses the relationship
between chromosomes, genes and dnscode and constructs this object appropriately as per the specification of the builder pattern