refactor: use a separate message display trait instead of println!() #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 79b146e.
litt/src/main.rs
Outdated
| // everything that does not require litt index | ||
|
|
||
| // Print existing litt indices | ||
| if cli.list { | ||
| println!("Currently available indices:"); | ||
| cli.display(Message::Info("Currently available indices:")); |
There was a problem hiding this comment.
We should add another type for Message called "CLI-MSG" or something. Because these messages are not Logs (where "Info: Currently available indices" would be wanted), but the actual user output where the output should simply be ("Currently available indices")
There was a problem hiding this comment.
Got it. I thought it might be good to emit semantic messages – so that the message knows what content it actually contains and then the implementation to display it, decides how to display that content. What do you think about that? See latest commits for this :)
index/src/index.rs
Outdated
| let relative_path = path | ||
| .path() | ||
| .strip_prefix(documents_path) | ||
| .map_err(|e| CreationError(e.to_string()))?; | ||
|
|
||
| let str_path = path.path().to_string_lossy().to_string(); | ||
| if !Self::checksum_is_equal(&str_path, existing_checksum).unwrap_or(false) { | ||
| println!("Adding document: {}", relative_path.to_string_lossy()); | ||
| message_display.display(Message::Info(&format!("Adding document: {}", relative_path.to_string_lossy()))); |
There was a problem hiding this comment.
See my comment above :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.