Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DensifyHaversine trait #1081

Merged
merged 12 commits into from
Oct 6, 2023
Merged

Conversation

JosiahParry
Copy link
Contributor

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

This PR adds a DensifyHaversine trait which enables users to densify line based spherical geometries.

It provides the ground work for enabling linestring segmentation on geographical coordinates which can be used by downstream libraries such as stplanr.

@michaelkirk
Copy link
Member

re: the CI failure - You might want to check out our usage of approx elsewhere for the sloppy floating point matching.

@JosiahParry
Copy link
Contributor Author

Oh thank goodness. That was an adventure!

Copy link
Member

@urschrei urschrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll leave it open in case anyone else wants to kick the tires.

geo/src/algorithm/densify_haversine.rs Show resolved Hide resolved
geo/src/algorithm/densify_haversine.rs Outdated Show resolved Hide resolved
Copy link
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@urschrei urschrei added this pull request to the merge queue Oct 6, 2023
Merged via the queue into georust:main with commit 2c99be6 Oct 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants