-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PPN photolysis #2371
base: main
Are you sure you want to change the base?
Adding PPN photolysis #2371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bexhorner for this update. I have a couple of comments:
-
Can you remove the
.DS_Store
file? This is a binary file, and we try to avoid adding those to Git repos. See this link for more info on how to delete a file from a PR: https://stackoverflow.com/questions/9498201/delete-file-from-pull-request-on-github/9498304#9498304 -
Would you be able add a note to the
KPP/fullchem/CHANGELOG_fullchem.md
about this update? -
Can you add the same updates in
KPP/fullchem/fullchem.eqn
toKPP/custom/custom.eqn
? We try to keep these synchronized.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bexhorner! We can try to get this into 14.5.0.
According to geoschem/Cloud-J#21, this update will also require updates to input files @bexhorner, could you post the |
@@ -31,7 +31,7 @@ MODULE CMN_FJX_MOD | |||
! Parameters | |||
!----------------------------------------------------------------------- | |||
|
|||
INTEGER, PARAMETER :: JVN_ = 166 ! Max number of J-values | |||
INTEGER, PARAMETER :: JVN_ = 167 ! Max number of J-values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only apply when running with FAST-JX, which is non-default except for the mercury simulation. Currently the max number of J-values is hard-coded in Cloud-J. Restructuring the memory is on the todo list so that we can instead pass it from the parent model.
Could you confirm that your tests used FAST-JX rather than Cloud-J? If using Cloud-J then this line needs to change: https://github.com/geoschem/Cloud-J/blob/03313bb6acde16a9962c3a5e18a3f78b4d220faa/src/Core/cldj_cmn_mod.F90#L47
yeah, @lizziel, changes were made with FAST-JX, so our updates will be missing changes specific to CLOUD-J. |
Okay, so the input files provided were not used for testing. They appear to be modifications of the Cloud-J tables files which do not include all GEOS-Chem species. We can look at the changes only and create Cloud-J input files that would work. |
@lizziel so the changes were made using FAST-JX and tested using the files below. The files I sent previously were applying the modifications used here to the Cloud-J tables. |
Name and Institution (Required)
Name: Bex Horner, @eamarais
Institution: University College London (UCL)
Describe the update
This update adds the PPN photolysis reaction to KPP as outlined in Horner et al. (2024).
PAN + OH and PPN + OH reactions are added using the structure-activity relationship approach.
The maximum number of J-values is increased to account for PPN photolysis.
Expected changes
NO2 concentrations will increase in the upper troposphere by ~30-60 pptv where PPN is abundant and thermally stable.
Reference(s)
Horner et al. 2024. "Vertical profiles of global tropospheric nitrogen dioxide (NO2) obtained via cloud-slicing" (https://doi.org/10.5194/egusphere-2024-1541)