Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for polygons to be styled with a point symbolizer #245

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rdewit
Copy link

@rdewit rdewit commented Mar 1, 2021

Description

This proof of concept PR aims to allow for polygons to be styled with point symbolizers.

I'm not sure if this is the right approach to take and look forward to feedback.

Example:

symbolizers: [
  {
    "kind": "Mark",
    "radius": 15,
    "opacity": 0.2,
    "color": "#0055ff",
    "wellKnownName": "Circle",
    "strokeColor": "#ffffff",
    "strokeWidth": 3,
    "strokeOpacity": 1
  },
  {
    "kind": "Icon",
    "image": "https://upload.wikimedia.org/wikipedia/commons/thumb/5/5f/Parking_icon.svg/128px-Parking_icon.svg.png",
    "size": 0.1,
    "rotate": 0,
    "opacity": 1
  },
  {
    "kind": "Text",
    "label": "Ward: {{WARD_NAME}}",
    "color": "#494f99",
    "haloWidth": 2,
    "haloColor": "#f7f7f9",
    "rotate": 0,
    "size": 12,
    "font": [
      "Verdana"
    ],
    "offset": [
      0,
      28
    ]
  }
]

geostyler-polygon-point-symbolizers

Related issues or pull requests

None at present.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)
  • I am unsure (we'll look into it together)

Do you introduce a breaking change?

  • Yes
  • No
  • I am unsure (no worries, we'll find out)

Checklist

  • I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
  • I have followed the guidelines for contributing
  • The proposed change fits to the content of the code of conduct
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally)
  • I'm lost; why do I have to check so many boxes? Please help!

@jansule
Copy link
Contributor

jansule commented Mar 1, 2021

That looks geat @rdewit!

@rdewit
Copy link
Author

rdewit commented Mar 3, 2021

That looks geat @rdewit!

Thanks, @jansule :-) Does that mean you're happy for me to continue on this path and get the PR ready for review?

@jansule
Copy link
Contributor

jansule commented Mar 3, 2021

Does that mean you're happy for me to continue on this path and get the PR ready for review?

Yes, absolutely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants