Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add PageFind full search #3

Closed
wants to merge 40 commits into from
Closed

Conversation

gerteck
Copy link
Owner

@gerteck gerteck commented Jul 31, 2024

To track progress of adding PageFind

Current Issues

  • How to index pages only if pagefind is enabled in plugins?
  • How to set a custom pagefind element / integrate into searchbar?
  • How to create a new custom vue component for page find?

Findings:

  • Search data for markbind native search is passed via "searchdata" field in the component!
    • I could probably pass in the default UI through this field as well.
    • Could pass in the search index through this as well.
      Require further investigation.

Archive:
Bug (fixed) found in searchbar component. (Native searchbar, where the prior results load in some random place only after scrolliing appears in the correct position)

Changelog:

packages/core/:

  • Add pagefind dependency for indexing files in package.json

  • Add indexing process in /src/Site

  • Updated compilerOptions to tsconfig.json to correctly convert .ts to appropriate .js code for module resolution.

package/core/src/plugins

  • Add pageFind.ts

package/vue-components/src

  • Update Searchbar.vue

Ignore: (To pass CI Checks)


Proposed commit message: (wrap lines at 72 characters)

Add PageFind


Checklist: ☑️

jingting1412 and others added 30 commits March 27, 2024 00:42
@gerteck
Copy link
Owner Author

gerteck commented Jul 31, 2024

Currently, the default PageFind UI does not fit into MarkBind's look?

image

Conditional rendering for indexing for pagefind
Fix bug of pagefind vue component
@gerteck gerteck marked this pull request as draft August 1, 2024 02:59
@gerteck gerteck closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants