Fixes REL1_39 compatibility

Changes hook to onPageDelete because there is already no data by the time SMW::SQLStore::BeforeDeleteSubjectComplete fires.
gesinn-it-pub · Jun 5, 2024 · 6e956de · 6e956de
1 parent 4bb66c3
commit 6e956de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/extension.json b/extension.json
@@ -24,8 +24,8 @@
     "SMW::SQLStore::AfterDataUpdateComplete": [
       "SDU\\Hooks::onAfterDataUpdateComplete"
     ],
-    "SMW::SQLStore::BeforeDeleteSubjectComplete": [
-      "SDU\\Hooks::onBeforeDeleteSubjectComplete"
+    "PageDelete": [
+      "SDU\\Hooks::onPageDelete"
     ]
   },
   "callback": "SDU\\Hooks::setup",

diff --git a/src/Hooks.php b/src/Hooks.php
@@ -26,8 +26,11 @@ public static function setup() {
 		}
 	}
 
-	public static function onBeforeDeleteSubjectComplete( SMWStore $store, Title $title ) {
-			$diWikiPage = SMWDIWikiPage::newFromTitle( $title );
+	// Note: at the time SMW::SQLStore::BeforeDeleteSubjectComplete fires there is no data already
+	// so the PageDelete hook is used
+	public static function onPageDelete( $page, $deleter, string $reason, $status, bool $suppress ) {
+			$store = smwfGetStore();
+			$diWikiPage = SMWDIWikiPage::newFromTitle( Title::newFromDBkey( $page->getDBkey() ) );
 			$smwData = $store->getSemanticData( $diWikiPage );
 			self::onAfterDataUpdateComplete( $store, $smwData, null );
 	}