update(group-join): add member details in response

src/group/group.service.ts

@@ -126,26 +126,29 @@ export class GroupService {
     const decodedGroupId = this.jwtService.verify(hashedGroupId);
     const groupId = decrypt(decodedGroupId.groupId);
 
-
     const group = await this.groupModel.findById(groupId).exec();
 
     if (!group) {
       throw new NotFoundException('Group not found');
     }
 
     const { members } = group;
-    // Check if the user is already a member of the group
+
     if (members.includes(userId)) {
       throw new BadRequestException('User already a member of the group');
     }
 
-    // Add the user to the group's members array
     members.push(userId);
 
-    // Save the updated group
-    await group.save();
+    const [, memberDetails] = await Promise.all([
+      group.save(),
+      this.userService.findUsersByIds(members),
+    ]);
 
-    return group; // Or some other meaningful response
+    return {
+      ...group.toObject(),
+      members: memberDetails,
+    };
   }
 
   async getAllUserGroups(userId) {

src/users/users.service.ts

@@ -129,4 +129,8 @@ export class UsersService {
   async editName(id, name) {
     return await this.userModel.findByIdAndUpdate(id, { name: name }).exec();
   }
+
+  async findUsersByIds(userIds: string[], projection = {}) {
+    return await this.userModel.find({ _id: { $in: userIds } }, projection).exec();
+  }
 }