-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use proper title in wails #662
Conversation
is this good already? |
Related: #695 |
|
a48b367
to
3b88e18
Compare
.github/workflows/http.yml
Outdated
else | ||
echo "PACKAGE_NAME=albyhub-Server-Linux-${{ matrix.build.arch }}" >> $GITHUB_ENV | ||
echo "PACKAGE_NAME=AlbyHub-Server-Linux-${{ matrix.build.arch }}-${SANITIZED_TAG}" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this work with our server update script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think file names should always be lowercased. If we change it then let's make sure everything is lowercase, then we less likely have issues on case-sensitive systems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, changing it to be lowercase 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the only issue. I think the Alby download links are to exact filenames, but now we add a version suffix on the filename. I think a change in getalby.com is also needed to ensure it picks up the file.
I originally suggested this because downloading two versions with the same filename ends up suffixing the second one with a (1).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally suggested this because downloading two versions with the same filename ends up suffixing the second one with a (1).
that's the reason why we add the version number to the filename? why would a user do that and even if the user does that why would it be a a problem?
Tested the Linux Desktop build, it seems to work well. I'm not sure we should do the same for the server builds though, will this create issues with our scripts? CC @bumi |
if we change the package name, then let's make sure we're using also the lowercased version in the scripts (need to be searched here in the repo and on getalbycom) |
ok, I missed the addition of the version to the filename. to me this just makes everything more complicated and then every script any everything needs to be aware of the changing filename. |
Removed adding version to file names and restricted to only fixing the app name in wails from "albyhub" to "Alby Hub" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
I tested the Wails build already on Linux with the last version which worked ok. I don't think anything has changed since then
Changes the title from
albyhub
in wails app toAlby Hub
Also fixes #466