feat: Alby OAuth Connector #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialogue using lndhub backend currently signed-off-by:pavanj914@gmail.com
pass connector field to accountContext use it to validate that account is alby or not eliminate alias hack to check alby account which can be changed signed-off-by:pavanj914@gmail.com
signed-off-by: pavanj914@gmail.com
signed-off-by: pavanj914@gmail.com
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
… connector without launching oauth flow
refactor generation of access token from oauth result
rolznz
changed the title
rolznz
changed the title
|
Some issues found so far:
|
rolznz
reviewed
Jun 5, 2023
rolznz
reviewed
Jun 5, 2023
rolznz
reviewed
Jun 5, 2023
rolznz
reviewed
Jun 5, 2023
Chore/web auth prototype feedback
…/lightning-browser-extension into web-auth-prototype
reneaaron
reviewed
Jul 6, 2023
reneaaron
reviewed
Jul 6, 2023
| const response = await msg.request( | ||
| "sendPayment", | ||
| { paymentRequest: paymentRequest }, | ||
| { | ||
| origin: navState.origin, | ||
| } | ||
| ); | ||
| if (response.error) { |
There was a problem hiding this comment.
Double check if that is needed? Is that really the case for existing connectors too, that no errors would be shown?
There was a problem hiding this comment.
There are multiple places where an error is returned, and the sendPayment action is wrapped in try/catch. I think we need this check, I don't understand how it worked before.
reneaaron
reviewed
Jul 6, 2023
reneaaron
reviewed
Jul 6, 2023
reneaaron
reviewed
Jul 6, 2023
…ng-browser-extension into web-auth-prototype
Co-authored-by: René Aaron <100827540+reneaaron@users.noreply.github.com>
rolznz
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet Interface with Oauth security
Type of change
feat: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
Alby.OAUTH.CONNECTOR.mp4
Checklist