-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add receive via bitcoin address button #2494
Conversation
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. Don't forget: keep earning sats! |
@stackingsaunter do you have a figma file @pavanjoshi914 can review to ensure he gets the styles right? For example, I think the action button normally should be at the bottom of the popup (to be confirmed) |
Let's put the button at the bottom and maybe center the text on the screen (so it's in the middle not on the top). Not super elegant but I think this is temporary solution anyway, as soon we can have swaps within the extension, so let's just merge it! |
do this looks good? cc @rolznz @stackingsaunter |
@pavanjoshi914 I found one minor spacing issue. I think the OR + buttons should be aligned at the bottom. @stackingsaunter could you confirm? Otherwise looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do another feedback loop and review the copy of this PR, other than that:
tACK
Regarding layout, not sure which feels better. @reneaaron @pavanjoshi914 @rolznz thoughts? Besides that small suggested small changes, otherwise tACK
|
styling button adding translations add ReceiveOnChain component resolve missing key prop for translations signed-off-by: Pavan Joshi <pavanj914@gmail.com>
handle conditional rendering of button center align text and button at button in onchainReceive Screen resolve problem of loading state while creating invoice signed-off-by: Pavan Joshi <pavanj914@gmail.com>
signed-off-by: Pavan Joshi <pavanjoshi914@gmail.com>
@pavanjoshi914 I think it is fine to change to "or". It might be nice to have a Divider component, and then we could also use it in the LND connect screen. What do you guys think? (Maybe this could be done as a follow up PR?) |
7337962
to
e16786d
Compare
let's do this in follow up pr in think |
@reneaaron can we merge this? |
Describe the changes you have made in this PR
add receive via bitcoin address button
styling button
adding translations
add ReceiveOnChain component
resolve missing key prop for translations
show button only when its an alby account
Type of change
feat
: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
Checklist