payment finalizer: never break loop #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 60.02% 60.06% +0.03%
==========================================
Files 50 50
Lines 3212 3195 -17
==========================================
- Hits 1928 1919 -9
+ Misses 1078 1070 -8
Partials 206 206
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we break the loop, then the queue will fill up.
We cannot unbind the queue because then we could miss payments that happened while lndhub was offline.
This means that we no longer have a need for the ticker - it's ok if our map never gets empty.