reserve fee amount in database #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwiidb
force-pushed
the
fix/add-fee-provision
branch
from
eaf8262
to
9e18911
Compare
|
Replaced by #395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the maximum fee a user can pay to the amount that is debited from their account.
In case of a succesful payment, this provisional max amount is credited to their balance again.
In case of a failed payment, the transaction entry is reversed anyway, but I had to change this to use the right amount (the one from the entry to reverse, which was the same as the invoice amount up until now, but will be different now).
To do: