Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connection URL and connect setup flow #1

Open
wants to merge 1 commit into
base: 7-wallet-connect-patch
Choose a base branch
from

Conversation

bumi
Copy link

@bumi bumi commented Apr 19, 2023

No description provided.


2. Client focussed:

The **client** generates a 32-byte random secret and stores it and uses this secret when it wants to perform an action. The corresponding public key must be passed to the **wallet service** to allow it to authorize the client. (e.g. using a deeplink to the **wallet service**)
Copy link

@rolznz rolznz Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be expanded to mention whether the relay and pubkey of the wallet service would be returned, or should the client know these in advance?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all depends, there might not be a return value. and the client needs to know the URL of the wallet service in advance otherwise it could not link the user there.
so if it know the wallet service URL it might also know the relay already.


- `relay` URL of the relay where the **wallet service** is connected and will be listening for events. May be more than one.
- `secret` 32-byte randomly generated hex encoded string. The **client** MUST use this to sign events and encrypt payloads when communicating with the **wallet service**.
- `pubkey` The hex-encoded pubkey for the `secret`
Copy link

@rolznz rolznz Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this the pubkey of the wallet service? Edit: sorry, I misread this. Is this just for convenience so the client doesn't need to get the public key from the secret themselves?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is these are depending on the flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants