Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/bip32: add rid #245

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

crypto/bip32: add rid #245

wants to merge 2 commits into from

Conversation

cychuang0924
Copy link
Contributor

Before submitting a pull request, please make sure the following is done:

Checklist

  • Fork the repository and create your new branch from master.
  • Please mention the name of community in Pull Request title.
  • Git Commit Messages
    • Use the present tense (Also in Pull Request title): "Add feature" not "Added feature"
    • Use the imperative mood (Also in Pull Request title): "Move cursor to..." not "Moves cursor to..."
    • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.02 🎉

Comparison is base (30835ee) 80.59% compared to head (baf0b34) 80.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   80.59%   80.61%   +0.02%     
==========================================
  Files         143      143              
  Lines       11202    11215      +13     
==========================================
+ Hits         9028     9041      +13     
  Misses       1369     1369              
  Partials      805      805              
Impacted Files Coverage Δ
crypto/bip32/master/peer.go 100.00% <ø> (ø)
crypto/bip32/child/share_manager.go 74.35% <66.66%> (-0.65%) ⬇️
crypto/bip32/master/0_initial_handler.go 76.98% <66.66%> (-0.52%) ⬇️
crypto/bip32/master/5_result_handler.go 71.69% <100.00%> (+0.54%) ⬆️
crypto/bip32/master/6_verify_handler.go 61.53% <100.00%> (ø)
crypto/bip32/master/master.go 73.84% <100.00%> (+0.40%) ⬆️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant