Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement open state and group mode for details shortcode #79

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

schliflo
Copy link

This enables users to manually set details to open.

Additionally via group mode, you can group items to achieve real accordion like behaviour.

@rhukster
Copy link
Member

Details is supposed to be a simple 'javascript' free solution. It seems you are trying to implement an accordion, which already has an open state and is by default 'grouped'. Is there a reason you are trying to make 'details' behave like 'accordion' ?

@schliflo
Copy link
Author

That's exactly what I'm trying to do. I'd be happy to reduce the PR to only implement the configurable open state - which should be configurable even if it's not used as an accordion.

@rhukster
Copy link
Member

OK, I get it, as this is a more 'accessible' accordion solution, might it not be better to use aria attributes rather than data attributes?

@rhukster
Copy link
Member

Just found this: https://www.scottohara.me/blog/2018/09/03/details-and-summary.html which is basically exactly what you are trying to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants