Access permissions 3: Smaller refactorings #6879
Open
+12
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
| @@ -17,7 +17,7 @@ | |||
| ); | |||
| }, | |||
| 'page.preview' => function (Page $page) { | |||
| if ($page->permissions()->can('preview') === true) { | |||
| if ($page->permissions()->preview() === true) { | |||
There was a problem hiding this comment.
When working on the user roles, I ran into some problems where using the magic caller methods was inferior to directly calling the ->can() method. And tried to start moving away from using the magic methods. I can't remember right now what was the exact problem (maybe related to testing) - I'll try to remember.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Smaller refactorings
Reasoning
Consistency and cleanup
Changelog
Housekeeping
Breaking changes
None
Docs
None
Ready?
For review team
Add lab and/or sandbox examples (wherever helpful)