Vertical scrolling support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just learned to code with Mimo and I'd appreciate any pointers on improving my code ❤️😄 |
kvdesa
requested changes
May 21, 2021
Comment on lines
+38
to
+39
| switch scrollDirection { | ||
| case .horizontal: |
There was a problem hiding this comment.
Instead of chaining 2 switch statements inside another switch, you can do it like this:
Suggested change
| switch scrollDirection { | |
| case .horizontal: | |
| switch (scrollDirection, snapPosition) { | |
| case (.horizontal, .left): | |
| case (.horizontal, .center): | |
| case (.horizontal, .right): | |
| case (.vertical, .center): | |
| case (.vertical, .top): | |
| case (.vertical, .bottom): | |
| case (.horizontal, .top), (.horizontal, .bottom), (.vertical, .left), (.vertical, .right): |
Comment on lines
+75
to
+82
| switch scrollDirection { | ||
| case .horizontal: | ||
| let itemHorizontalPosition: CGFloat | ||
|
|
||
| switch snapPosition { | ||
| case .left: | ||
| itemHorizontalPosition = layoutAttributes.frame.minX - collectionView.contentInset.left | ||
| case .center: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for horizontal scrolling moved inside switch statements for
scrollDirection.I added three cases for
.verticalscrolling:.top.center.bottomThe cells of a collectionView snap to the top, center, or bottom when the
scrollDirectionis set tovertical.