Skip to content

Commit

Permalink
updated default value for share status in route53resolver (#7496)
Browse files Browse the repository at this point in the history
  • Loading branch information
macnev2013 authored Mar 20, 2024
1 parent 3e90012 commit 005ead3
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
6 changes: 0 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,6 @@ test-only:

test: lint test-only

terraformtests:
@echo "Make sure that the MotoServer is already running on port 4566 (moto_server -p 4566)"
@echo "USAGE: make terraformtests SERVICE_NAME=acm TEST_NAMES=TestAccACMCertificate"
@echo ""
cd tests/terraformtests && bin/run_go_test $(SERVICE_NAME) "$(TEST_NAMES)"

test_server:
@TEST_SERVER_MODE=true pytest -sv --cov=moto --cov-report xml ./tests/

Expand Down
2 changes: 1 addition & 1 deletion moto/route53resolver/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def __init__(
f"[Trace id: 1-{mock_random.get_random_hex(8)}-{mock_random.get_random_hex(24)}] "
f"Successfully created Resolver Rule"
)
self.share_status = "SHARED_WITH_ME"
self.share_status = "NOT_SHARED"
self.creation_time = datetime.now(timezone.utc).isoformat()
self.modification_time = datetime.now(timezone.utc).isoformat()

Expand Down
2 changes: 1 addition & 1 deletion tests/test_route53resolver/test_route53resolver_rule.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def test_route53resolver_create_resolver_rule(): # pylint: disable=too-many-loc
assert rule["TargetIps"][0]["Port"] == target_ips[0]["Port"]
assert rule["ResolverEndpointId"] == endpoint_id
assert rule["OwnerId"] == ACCOUNT_ID
assert rule["ShareStatus"] == "SHARED_WITH_ME"
assert rule["ShareStatus"] == "NOT_SHARED"

time_format = "%Y-%m-%dT%H:%M:%S.%f+00:00"
now = datetime.now(timezone.utc).replace(tzinfo=None)
Expand Down

0 comments on commit 005ead3

Please sign in to comment.