Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of some requirements versions. #3744

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

aknrdureegaesr
Copy link
Contributor

You can now in all requirements files replace the '>=' with '==', pip will install this, and the tests will succeed.

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable). Not applicable.
  • I tested my changes.

Description

This pertains to #3734. It is some improvement on the previous state of our dependencies. This PR presents a set of minimal versions that makes the test succeed.

Extensive running of some one-off script is at the base of this. The script mixes dependency versions, tries to throw the combination at pip, and, in case that succeeds, tries to run pytest. Code coverage was switched off during the pytest runs for performance. (Is that script wanted? I can contribute it.)

The versions come from some pip freeze --all output. So you can replace all >= in the requirements files with == and throw the result at pip: The pip run will succeed and so will a pytest run in that venv.

But this really only pertains the tests. And the Nikola tests apparently don't test everything.

How do I know? With my venv with all == as described, I tried to build nikola-site with nikola auto -b and that failed, I believe when the first rebuild was asked for after editing. I started a feeble attempt to get that going by timid updates, one such update is included, but gave up on the second problem.

@Kwpolska Kwpolska added this to the v8.3.1 milestone Jan 16, 2024
You can now in all requirements files replace the '>=' with '==',
it will install, and the tests will succeed.

(However, the `nikola-site` example will not build.)
@Kwpolska Kwpolska enabled auto-merge (squash) January 17, 2024 23:33
@Kwpolska Kwpolska merged commit fce24d4 into getnikola:master Jan 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants