Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submission attachment API #104

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

spwoodcock
Copy link

This PR

What has been done to verify that this works as intended?

  • Tests
    image
  • Verify with real data / ODK Central (not done yet!)

Why is this the best possible solution? Were any other approaches considered?

  • I tried to keep as consistent as possible with existing code.
  • There is a FormDraftAttachmentService with a single get and the SubmissionService itself to work from.
  • Hopefully it fits in with requirements 🤞- update as needed!

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

  • No changes to existing services.
  • Additive changes only.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

  • No docs updated yet! But they can be once this PR is finalised 👍

Before submitting this PR, please make sure you have:

  • included test cases for core behavior and edge cases in tests
  • run python -m unittest and verified all tests pass
  • run ruff format pyodk tests and ruff check pyodk tests to lint code
  • verified that any code or assets from external sources are properly credited in comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant