Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorize the terminal with pretty colors #613

Closed
wants to merge 7 commits into from

Conversation

barbaraDorame
Copy link
Contributor

Adresses #541

@pep8speaks
Copy link

pep8speaks commented Apr 26, 2019

Hello @barbaraDorame! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-26 05:29:19 UTC

@barbaraDorame
Copy link
Contributor Author

It runs, and in local it’s fine, i don’t know why is all blue and randomly white in travis 🤔, any idea?

Sent with GitHawk

@ivotron
Copy link
Collaborator

ivotron commented Apr 26, 2019

thanks a lot @barbaraDorame! And sorry! I didn't realize that you were working on this, otherwise I would have suggested you wait for #598, as this colorization will have to be implemented in the log.py file (which contains a definition of a logging custom formatter)

@ivotron
Copy link
Collaborator

ivotron commented Jul 11, 2019

gonna address this on another PR

@ivotron ivotron closed this Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants