Address PR Review Feedback

Signed-off-by: Maninderjit Bindra <maninder.bindra@gmail.com>
getporter · Aug 31, 2023 · 053149a · 053149a
1 parent 245337f
commit 053149a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/pkg/porter/list.go b/pkg/porter/list.go
@@ -29,7 +29,6 @@ const (
 
 // ListOptions represent generic options for use by Porter's list commands
 type ListOptions struct {
-	installationOptions
 	printer.PrintOptions
 	AllNamespaces bool
 	Namespace     string
@@ -366,7 +365,7 @@ func doesInstallationMatchFieldSelectors(installation DisplayInstallation, field
 
 // Check if the installation has the field with the value
 // e.g. installationHasFieldWithValue(installation, "bundle.version", "0.2.0") => true if installation.Bundle.Version (for which json tag is bunde.version) == "0.2.0"
-func installationHasFieldWithValue(installation DisplayInstallation, fieldJsonTagPath string, value interface{}) bool {
+func installationHasFieldWithValue(installation DisplayInstallation, fieldJsonTagPath string, value string) bool {
 
 	fieldJsonTagPathParts := strings.Split(fieldJsonTagPath, ".")
 	current := reflect.ValueOf(installation)

diff --git a/pkg/porter/list_test.go b/pkg/porter/list_test.go
@@ -483,7 +483,7 @@ func Test_installationHasFieldWithValue(t *testing.T) {
 	type args struct {
 		installation     DisplayInstallation
 		fieldJsonTagPath string
-		value            interface{}
+		value            string
 	}
 	tests := []struct {
 		name string