Skip to content

Commit

Permalink
add defers
Browse files Browse the repository at this point in the history
Signed-off-by: Sarah Christoff <28318173+schristoff@users.noreply.github.com>
  • Loading branch information
schristoff committed Feb 4, 2024
1 parent 8b890fd commit 5d80384
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions build/testdata/bundles/mysql/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Dockerfile
.cnab
2 changes: 2 additions & 0 deletions build/testdata/bundles/wordpress/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Dockerfile
.cnab
2 changes: 2 additions & 0 deletions build/testdata/bundles/wordpressv2/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Dockerfile
.cnab
1 change: 1 addition & 0 deletions cmd/porter/completion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ func TestCompletion(t *testing.T) {

func TestCompletion_SkipConfig(t *testing.T) {
p := porter.NewTestPorter(t)
defer p.Close()
cmd := buildCompletionCommand(p.Porter)
shouldSkip := shouldSkipConfig(cmd)
require.True(t, shouldSkip, "expected that we skip loading configuration for the completion command")
Expand Down
1 change: 1 addition & 0 deletions pkg/grpc/portergrpc/installation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ func TestListInstallationsReturnsErrorIfUnableToGetPorterConnectionFromRequestCo

func setupTestPorterWithInstallations(t *testing.T, installations []instInfo) (context.Context, map[string]porter.DisplayInstallation) {
p := porter.NewTestPorter(t)
defer p.Close()
insts := map[string]porter.DisplayInstallation{}
for _, inst := range installations {
installation := storage.NewInstallation(inst.namespace, inst.name)
Expand Down
1 change: 1 addition & 0 deletions tests/integration/dependenciesv2_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ func TestSharedDependencies(t *testing.T) {
t.Parallel()

p := porter.NewTestPorter(t)
defer p.Close()
ctx := p.SetupIntegrationTest()

p.Config.SetExperimentalFlags(experimental.FlagDependenciesV2)
Expand Down

0 comments on commit 5d80384

Please sign in to comment.