Skip to content

Commit

Permalink
Reenable bundle reuse test
Browse files Browse the repository at this point in the history
No matter what I try I cannot get this test to fail anymore. Tried to
increase the iterations to 100 without getting any fails, not in Github
Actions or locally.
Based on that the test is reenabled, and then it should be monitored
if the build becomes unstable again.

Signed-off-by: Kim Christensen <kimworking@gmail.com>
  • Loading branch information
kichristensen committed Apr 9, 2024
1 parent 7310b18 commit 871ca9c
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions tests/integration/build_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,10 @@ func TestRebuild(t *testing.T) {
// This is a regression test for a bug where the manifest would be considered out-of-date when nothing had changed
// caused by us using a go map when comparing the mixins used in the bundle, which has inconsistent sort order...

//todo: This test is flaky still and upsetting CI
// for i := 0; i < 5; i++ {
// _, output = test.RequirePorter("explain")
// tests.RequireOutputContains(t, output, "Bundle is up-to-date!", "expected the previous build to be reused")
// }
for i := 0; i < 10; i++ {
_, output = test.RequirePorter("explain")
tests.RequireOutputContains(t, output, "Bundle is up-to-date!", "expected the previous build to be reused")
}

bumpBundle()

Expand Down

0 comments on commit 871ca9c

Please sign in to comment.