Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noop plugins #2218

Draft
wants to merge 1 commit into
base: release/v1
Choose a base branch
from

Conversation

carolynvs
Copy link
Member

What does this change

Add a storage plugin that doesn't store anything. This can be used by people who want to use Porter to install bundles, but don't ever care about seeing previously installed bundles.

Open Questions

  • What are the pros/cons of making this the default storage plugin over mongodb-docker?
  • Who do we recommend should use this?
  • Should this also come with noop secret plugin? Otherwise they need to configure a secret plugin too.
  • I suspect people who don't want to keep records, may want a quick way to toggle this. Let's make the doc super clear how to use the environment variable PORTER_DEFAULT_STORAGE_PLUGIN to toggle noop mode. Perhaps we need a flag at the global level that toggles the noop plugins?

What issue does it fix

I have seen users use porter to just run the install action of a bundle and have no interest in using porter to manage the resources created by that bundle. They don't want to setup a mongodb instance, or need to cleanup a docker container/volume after running the bundle.

Notes for the reviewer

None

Checklist

  • Did you write tests? TODO
  • Did you write documentation? TODO
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Add a storage plugin that doesn't store anything. This can be used by
people who want to use Porter to install bundles, but don't ever care
about seeing previously installed bundles.

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
@carolynvs carolynvs added the playground 🙈 Pull request to try stuff out and see if it builds. Don't look! label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playground 🙈 Pull request to try stuff out and see if it builds. Don't look!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant