Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add use custom dockerfile #2803

Closed

Conversation

alekseybb197
Copy link
Contributor

What does this change

Added command line flag to disable dockerfile generation. The flag changes the default behavior and causes the custom template to be used as is without changes.

What issue does it fix

Closes #2802

Checklist

  • [+] Did you write tests?
  • [+] Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Reviewer Checklist

  • Comment with /azp run test-porter-release if a magefile or build script was modified
  • Comment with /azp run porter-integration if it's a non-trivial PR

Signed-off-by: Aleksey Barabanov <alekseybb@gmail.com>
Signed-off-by: Aleksey Barabanov <alekseybb@gmail.com>
@schristoff
Copy link
Member

Due to discussions had in the Porter community meeting about this use case, we are deciding not to go forward with merging this feature into Porter. However, I'm happy to continue discussions on the issue to see if we can look into this again. :)

@schristoff schristoff closed this Aug 1, 2023
@alekseybb197
Copy link
Contributor Author

I will keep my code for future discussions and work on it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants